Topics

anybody know about windows builds on 1.3-rel?


Mats Wichmann
 

There are a few patches pending against 1.3-rel - I know one is some
maintenance on the demo, which is written to run against 1.3.

CI builds don't pass on these patches, with two specific builds always
failing - the 64-bit/vs2015 build, and the 32-bit/vs2013 build (the
other two Windows builds don't seem to run these tests). The error
message is not the same, though the test is, and we don't see this in
master or 1.4-rel. Does anyone know what could have rotted? I'm unable
to provide the developers with any useful help.


iotivity-verify-windows-amd64-vs2015

15:21:03 [ RUN ] AMACLResourceTest.CBORAMACLConversion
15:21:03 resource\csdk\security\unittest\amaclresourcetest.cpp(86):
error: Value of: AmaclToCBORPayload(secAmacl, &psStorage, &size)
15:21:03 Actual: 255
15:21:03 Expected: OC_STACK_OK
15:21:03 Which is: 0
15:21:03 resource\csdk\security\unittest\amaclresourcetest.cpp(91):
error: Value of: NULL != psStorage
15:21:03 Actual: false
15:21:03 Expected: true
15:21:03 [ FAILED ] AMACLResourceTest.CBORAMACLConversion (1 ms)

iotivity-verify-windows-x86-vs2013

15:23:50 [ RUN ] AMACLResourceTest.CBORAMACLConversion
15:23:50 23:50.464 ERROR: OIC_SRM_AMACL: Failed Closing Amacl Map. with
cbor error: 'too few items added to encoder'.
15:23:50 resource\csdk\security\unittest\amaclresourcetest.cpp(86):
error: Value of: AmaclToCBORPayload(secAmacl, &psStorage, &size)
15:23:50 Actual: 255
15:23:50 Expected: OC_STACK_OK
15:23:50 Which is: 0
15:23:50 resource\csdk\security\unittest\amaclresourcetest.cpp(91):
error: Value of: NULL != psStorage
15:23:50 Actual: false
15:23:50 Expected: true
15:23:50 [ FAILED ] AMACLResourceTest.CBORAMACLConversion (1 ms)


Nathan Heldt-Sheller
 

Hi Mats,

I'm not sure why these tests specifically would fail, as they appear to be testing the CBOR conversion code which should be unchanged. However the /amacl Resource itself is not even instantiated in IoTivity, and the implementation is incomplete (see "AMACL_RESOURCE_IMPLEMENTATION_COMPLETE" in resourcemanager.c)... I'd suggest removing these unit tests from the build if they are causing trouble.

Thanks,
Nathan

-----Original Message-----
From: iotivity-dev@lists.iotivity.org [mailto:iotivity-dev@lists.iotivity.org] On Behalf Of Mats Wichmann
Sent: Thursday, August 23, 2018 9:43 AM
To: IoTivity Developer List <iotivity-dev@lists.iotivity.org>
Subject: [dev] anybody know about windows builds on 1.3-rel?


There are a few patches pending against 1.3-rel - I know one is some maintenance on the demo, which is written to run against 1.3.

CI builds don't pass on these patches, with two specific builds always failing - the 64-bit/vs2015 build, and the 32-bit/vs2013 build (the other two Windows builds don't seem to run these tests). The error message is not the same, though the test is, and we don't see this in master or 1.4-rel. Does anyone know what could have rotted? I'm unable to provide the developers with any useful help.


iotivity-verify-windows-amd64-vs2015

15:21:03 [ RUN ] AMACLResourceTest.CBORAMACLConversion
15:21:03 resource\csdk\security\unittest\amaclresourcetest.cpp(86):
error: Value of: AmaclToCBORPayload(secAmacl, &psStorage, &size)
15:21:03 Actual: 255
15:21:03 Expected: OC_STACK_OK
15:21:03 Which is: 0
15:21:03 resource\csdk\security\unittest\amaclresourcetest.cpp(91):
error: Value of: NULL != psStorage
15:21:03 Actual: false
15:21:03 Expected: true
15:21:03 [ FAILED ] AMACLResourceTest.CBORAMACLConversion (1 ms)

iotivity-verify-windows-x86-vs2013

15:23:50 [ RUN ] AMACLResourceTest.CBORAMACLConversion
15:23:50 23:50.464 ERROR: OIC_SRM_AMACL: Failed Closing Amacl Map. with cbor error: 'too few items added to encoder'.
15:23:50 resource\csdk\security\unittest\amaclresourcetest.cpp(86):
error: Value of: AmaclToCBORPayload(secAmacl, &psStorage, &size)
15:23:50 Actual: 255
15:23:50 Expected: OC_STACK_OK
15:23:50 Which is: 0
15:23:50 resource\csdk\security\unittest\amaclresourcetest.cpp(91):
error: Value of: NULL != psStorage
15:23:50 Actual: false
15:23:50 Expected: true
15:23:50 [ FAILED ] AMACLResourceTest.CBORAMACLConversion (1 ms)