Topics

Call for review


Ondrej Tomcik
 

Hello,

Would like to ask you to review these changes

https://gerrit.iotivity.org/gerrit/#/c/26853/1

https://gerrit.iotivity.org/gerrit/#/c/26849/1

https://gerrit.iotivity.org/gerrit/#/c/26851/1

 

Thanks

 

Ondrej Tomcik :: KISTLER :: measure, analyze, inovate

 


Gregg Reynolds
 



On Tue, Sep 4, 2018, 2:51 AM Ondrej Tomcik <ondrej.tomcik@...> wrote:

Hello,

Would like to ask you to review these changes

https://gerrit.iotivity.org/gerrit/#/c/26853/1

g_sessionlist is static, only used in one file? If so, why "g_"?

https://gerrit.iotivity.org/gerrit/#/c/26849/1

https://gerrit.iotivity.org/gerrit/#/c/26851/1

 

Thanks

 

Ondrej Tomcik :: KISTLER :: measure, analyze, inovate

 


Jozef Kralik
 

Hello.
Would like to ask you again to review these changes:
https://gerrit.iotivity.org/gerrit/#/c/26849/2
https://gerrit.iotivity.org/gerrit/#/c/26851/2
https://gerrit.iotivity.org/gerrit/#/c/26853/4

Thanks

Jozef Kralik:: KISTLER :: measure, analyze, inovate


Nathan Heldt-Sheller
 

Thanks for these important and well-written patches!  And big thanks to George Nash and Ondrej Tomcik for the thorough code review.

 

All 3 patches have been merged to 1.4-rel.

 

Jozef, please cherry pick all 3 to master as soon as you have time, to avoid any extra merge work.

 

Thanks again!

Nathan

 

From: iotivity-dev@... [mailto:iotivity-dev@...] On Behalf Of Jozef Kralik
Sent: Friday, September 7, 2018 5:33 AM
To: iotivity-dev@...
Subject: Re: [dev] Call for review

 

Hello.
Would like to ask you again to review these changes:
https://gerrit.iotivity.org/gerrit/#/c/26849/2
https://gerrit.iotivity.org/gerrit/#/c/26851/2
https://gerrit.iotivity.org/gerrit/#/c/26853/4

Thanks

Jozef Kralik:: KISTLER :: measure, analyze, inovate


Mats Wichmann
 

On 09/10/2018 11:30 AM, Nathan Heldt-Sheller wrote:
Thanks for these important and well-written patches! And big thanks to George Nash and Ondrej Tomcik for the thorough code review.

All 3 patches have been merged to 1.4-rel.

Jozef, please cherry pick all 3 to master as soon as you have time, to avoid any extra merge work.

Thanks again!

Nathan
merging preserves history better (certainly has cleaner looking graphs)
than cherry picking as a cherry pick is a new commit, not the
application of an existing commit to a different branch. for the past
year plus, we've been doing merges into master of things which have been
added to release branches. so merge if possible :) phil had some
stuff to help with that, maybe he can share.


Nathan Heldt-Sheller
 

Mats, good point, we've not EOL'd the 1.4-rel -> master process so that should happen next time Phil brings it forward. Sorry!

Phil, please add Jozef as a reviewer to the next 1.4-rel -> master merge.

Jozef, please make sure your code is correctly merged in that change!

Thanks,

Nathan

-----Original Message-----
From: Mats Wichmann [mailto:mats@wichmann.us]
Sent: Monday, September 10, 2018 10:43 AM
To: Heldt-Sheller, Nathan <nathan.heldt-sheller@intel.com>; Jozef Kralik <jojo.lwin@gmail.com>; iotivity-dev@lists.iotivity.org
Subject: Re: [dev] Call for review

On 09/10/2018 11:30 AM, Nathan Heldt-Sheller wrote:
Thanks for these important and well-written patches! And big thanks to George Nash and Ondrej Tomcik for the thorough code review.

All 3 patches have been merged to 1.4-rel.

Jozef, please cherry pick all 3 to master as soon as you have time, to avoid any extra merge work.

Thanks again!

Nathan
merging preserves history better (certainly has cleaner looking graphs) than cherry picking as a cherry pick is a new commit, not the application of an existing commit to a different branch. for the past year plus, we've been doing merges into master of things which have been
added to release branches. so merge if possible :) phil had some
stuff to help with that, maybe he can share.